Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.24.0 #1180

Merged
merged 19 commits into from
Dec 26, 2023
Merged

v4.24.0 #1180

merged 19 commits into from
Dec 26, 2023

Conversation

Cabecinha84
Copy link
Member

@Cabecinha84 Cabecinha84 commented Dec 26, 2023

  • Marketplace improvements;
  • Auto node selection for enterprise apps only selects nodes under kyc;
  • Update packages;
  • Other small improvements.

@Cabecinha84 Cabecinha84 requested a review from TheTrunk December 26, 2023 12:49
Copy link

gitguardian bot commented Dec 26, 2023

⚠️ GitGuardian has uncovered 17 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8398280 PGP Private Key a87c439 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key a87c439 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 4237e6c HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 0232f30 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key b8455d1 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 63b9204 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 63b9204 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key f29cc7c HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 0232f30 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key b8455d1 HomeUI/dist/js/index.js View secret
8398280 PGP Private Key 4237e6c HomeUI/dist/js/index.js View secret
8398280 PGP Private Key f29cc7c HomeUI/dist/js/index.js View secret
9015359 PGP Private Key c1d7e96 HomeUI/dist/js/index.js View secret
9015359 PGP Private Key c1d7e96 HomeUI/dist/js/index.js View secret
9015359 PGP Private Key dbaca9e HomeUI/dist/js/index.js View secret
9015359 PGP Private Key dbaca9e HomeUI/dist/js/index.js View secret
9015359 PGP Private Key ab1a1e8 HomeUI/dist/js/index.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@TheTrunk TheTrunk merged commit b5fbfe0 into master Dec 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants