Syslog Implementation #1437
Open
Syslog Implementation #1437
+132
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented helper function `getNextAvailableIPForApp` using the ip library to inspect the Docker network (derived from the app name) and automatically determine the next available static IP. - Updated `appDockerCreate` to conditionally include the `NetworkingConfig` section: - If an auto-assigned IP is available, it is set via `EndpointsConfig` using the object spread operator. - If no IP is available (i.e. the helper returns null), the `NetworkingConfig` is omitted so that Docker assigns a dynamic IP. - Integrated syslog functionality: - Checks environment parameters for syslog roles (e.g., `LOG=SEND` and `LOG=COLLECT`). - If the container is a log sender and a syslog collector is identified, the collector’s IP is retrieved (via `getContainerIP`) and used to configure the container's `LogConfig` with a syslog address (e.g., `udp://<collectorIP>:514`). - This commit enhances container creation by supporting both automatic static IP assignment and integrated syslog logging.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1437 +/- ##
===============================================
- Coverage 47.84% 47.77% -0.08%
===============================================
Files 50 60 +10
Lines 15622 18404 +2782
===============================================
+ Hits 7475 8793 +1318
- Misses 8147 9611 +1464 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(appDockerCreate): add conditional static IP assignment with syslog integration
getNextAvailableIPForAppusing the ip library to inspect the Docker network (derived from the app name) and automatically determine the next available static IP.appDockerCreateto conditionally include theNetworkingConfigsection:EndpointsConfigusing the object spread operator.NetworkingConfigis omitted so that Docker assigns a dynamic IP.LOG=SENDandLOG=COLLECT).getContainerIP) and used to configure the container'sLogConfigwith a syslog address (e.g.,udp://<collectorIP>:514).