-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WavDecoder::total_duration. #699
Conversation
D'oh! Pointy hat to me, good one. I probably copied the same mistake in the Line 50 in 8fd0337
|
Ok, I'm checking and I will fix it. |
you've got this (very nice) comment there that points to the opposite: // `samples` in FLAC means "inter-channel samples" aka frames
// so we do not divide by `self.channels` here. |
9254570
to
78142a6
Compare
It was ignoring the channels count.
78142a6
to
8b24324
Compare
I renamed |
🤦♂️ I will go to bed now 😄 |
I'm gonna go and add some integration tests to prevent this from ever regressing. Looks good to merge for me |
I should follow your example, I just spend some time writing total duration tests before realizing I already did that... three days ago (to be merged as part of #697). |
It was ignoring the channels count.