Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement bake-kdf function #88

Merged
merged 1 commit into from
Nov 5, 2024
Merged

implement bake-kdf function #88

merged 1 commit into from
Nov 5, 2024

Conversation

makavity
Copy link
Contributor

Need RustCrypto/hashes#520 for merge

@makavity makavity marked this pull request as draft November 20, 2023 12:37
@makavity makavity mentioned this pull request Nov 20, 2023
Merged
newpavlov
newpavlov reviewed Nov 22, 2023
View reviewed changes
bake-kdf/src/lib.rs Outdated Show resolved Hide resolved
@makavity makavity marked this pull request as ready for review November 24, 2023 09:23
@makavity makavity changed the title [wip] implement bake-kdf function implement bake-kdf function Jan 3, 2024
@makavity
Copy link
Contributor Author

@newpavlov hey, could you take a look?

@makavity makavity force-pushed the master branch 3 times, most recently from 422db56 to c2a3444 Compare July 25, 2024 17:53
@makavity
Copy link
Contributor Author

@newpavlov hey, could you check it? Need it for PAKE algorithm.

@newpavlov
Copy link
Member

@makavity
I've resolved merge conflicts and tweaked the code. The main change is around APIs, the functions now accept u8 buffers instead of u32. This makes code a bit more natural and evades the endianness change roundtrip. Compiler should be able to handle potential performance issues around [u32; N] -> [u8' 4 * N] -> [u32; N] conversions by inlining code.

@newpavlov newpavlov merged commit 0e6724b into RustCrypto:master Nov 5, 2024
27 checks passed
@makavity
Copy link
Contributor Author

makavity commented Nov 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov Awaiting requested review from newpavlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makavity @newpavlov