Prevent panic when creating a Schnorr from slice #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nature Introduced new safe builders, same as bign256 and sm2: - `split_at` can panic if it receives a slice shorter than `Self::BYTES / 2` - `split_at` is now use in the new `from_bytes` that accepts only byte arrays or the right size - `from_slice` uses a safe conversion that does not panic when the slice is too short - `try_from` slice uses `from_slice` internally, so it does not panic when a short slice is passed - introduce safe type conversion from SignatureBytes
germanop
force-pushed
the
schnorr_try_from_panic
branch
from
5b875c1 to
a62494e
Compare
tarcieri
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass a byte slice shorter than 32 bytes to Schnorr's Signature::try_from, it panics.
There is a unit test as first commit to test behaviour before and after the fix.
An easy fix would have been to check in
try_fromif the slice was shorted thanSelf::BYTES / 2but this patch makes it more similar tobign256andsm2.