Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sm2: add SM2PKE support #1069
sm2: add SM2PKE support #1069
Changes from 4 commits
640adca
524e1e5
e52f48b
c08fa2d
557fe89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work on heapless
no_std
targets, nor is thealloc
feature being enabled by thepke
feature.It seems like you could get rid of these dynamic allocations if you switched from
DynDigest
to a genericD
parameter like you have fordecrypt_digest
and bound on theOutputSizeUser
trait, which will give you access to a compile-time output size which can be used to allocate an appropriately sized array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once saw an issue related to using
OutputSizeUser::USIZE
to create a new array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to solve this problem with the
hybird_array
, but I needed a little time to adjust the other places where thealloc
feature was used