Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1109

Closed
wants to merge 4 commits into from
Closed

Fix typos #1109

wants to merge 4 commits into from

Conversation

Marcofann
Copy link

This pull request addresses grammatical errors in comments within multiple ecdsa.rs files across the repository. The phrase "a SHA" was replaced with "an SHA" to ensure grammatical correctness when referring to words beginning with a vowel sound.

Files Updated

  1. p192/src/test_vectors/ecdsa.rs
    • Corrected: "a SHA-1""an SHA-1"
  2. p224/src/test_vectors/ecdsa.rs
    • Corrected: "a SHA-224""an SHA-224"
  3. p384/src/test_vectors/ecdsa.rs
    • Corrected: "a SHA-384""an SHA-384"
  4. p521/src/test_vectors/ecdsa.rs
    • Corrected: "a SHA-512""an SHA-512"

@soatok
Copy link

soatok commented Jan 4, 2025

SHA-1 is often pronounced "shaw" not "Ess Aych Ayy"

@tarcieri
Copy link
Member

tarcieri commented Jan 4, 2025

"an SHA" seems weird to me

@tarcieri tarcieri closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants