Skip to content

Commit

Permalink
const-oid: fix Encoder size check and off-by-one error (#1304)
Browse files Browse the repository at this point in the history
The `Encoder` previously returned `Error::Length` even when there was
one remaining byte in the buffer.

This fixes that error and adds an edge case test.
  • Loading branch information
tarcieri authored Jan 5, 2024
1 parent 215e388 commit 12820eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion const-oid/src/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ impl<const MAX_SIZE: usize> Encoder<MAX_SIZE> {
let nbytes = base128_len(arc);

// Shouldn't overflow on any 16-bit+ architectures
if self.cursor + nbytes + 1 >= ObjectIdentifier::MAX_SIZE {
if self.cursor + nbytes + 1 > MAX_SIZE {
return Err(Error::Length);
}

Expand Down

0 comments on commit 12820eb

Please sign in to comment.