Kupyna: implemented hashing function #621

AnarchistHoneybun · 2024-10-11T16:20:29Z

Scrapped previous PR since it ran into a lot of problems. I'm aware that #601 exists, creating this one to check against the repo's test suite as I iterate on my implementation, and potentially make it the main pr for kupyna if the other one becomes inactive.

Currently the implementation does everything the paper describes (testing leaves a bit to be desired) so step one is to clean up any linter complaints, and then proceed to making it no-std compatible.

AnarchistHoneybun · 2024-10-11T16:33:55Z

@newpavlov could you give me some idea on why the tests are failing right now? I don't think I've touched the Cargo.toml let alone the version of digest; checked and it's the same version as that present in some other toml's. Any idea why this could be happening?

kupyna/Cargo.toml

kupyna/LICENSE

kupyna/README.md

kupyna/src/main.rs

kupyna/src/sub_units/t_xor_plus/tests/test_individual_layers.rs

kupyna/.gitignore

kupyna/Cargo.toml

AnarchistHoneybun · 2024-10-11T18:11:33Z

Might be a bit unrelated but when I try cargo run on my local it gives me this error:

error: failed to select a version for `digest`.
    ... required by package `kupyna v0.1.0 (/home/vrin/kupyna_hashes_contrib/kupyna)`
versions that meet the requirements `=0.11.0-pre.9` are: 0.11.0-pre.9

all possible versions conflict with previously selected packages.

  previously selected package `digest v0.11.0-pre.8`
    ... which satisfies dependency `digest = "=0.11.0-pre.8"` of package `ascon-hash v0.3.0-pre (/home/vrin/kupyna_hashes_contrib/ascon-hash)`

failed to select a version for `digest` which could resolve this conflict

now this worked fine before updating the toml. Post toml update the CI is fine, but the main function is failing. Is this expected behaviour?

newpavlov · 2024-10-11T20:01:03Z

Try to rebase your branch to master.

AnarchistHoneybun · 2024-10-12T04:21:33Z

I don't have a lot (read any) experience with rebasing, sadly. Could you explain a bit more?

newpavlov · 2024-10-12T04:42:14Z

You should be able to rebase to this repos master using something like this (it accounts for the fact that you've forked from a fork):

git remote add upstream [email protected]:RustCrypto/hashes.git
git pull upstream
git checkout main_repo_contrib
git rebase upstream/master
git push --force

Note that I do not guarantee correctness of these commands since I wrote them from memory.

kupyna/src/sub_units/t_xor_plus/tests/test_individual_layers.rs

…sh code size

… dependencies

… the row and col constants

# Conflicts: # README.md

…dule

AnarchistHoneybun · 2025-02-26T17:10:34Z

hey @newpavlov , I think it's almost all groestl-ish now. I still have to move it to no_std and fix a small bug but like, any other large changes you'd wish to see?

newpavlov · 2025-02-26T20:29:17Z

I will try to take a look at the code in the following weeks. Meanwhile, could you bump edition to 2024 and MSRV to 1.85 similarly to the other crates in this repo? It's also worth to rebase to master.

newpavlov · 2025-02-26T20:31:15Z

kupyna/Cargo.toml

+
+[dev-dependencies]
+digest = { version = "=0.11.0-pre.10", features = ["dev"] }
+hex-literal = "0.4"


Update to hex-literal = "1" after MSRV is bumped to 1.85. You also don't need to duplicate it in [dev-dependencies] if it's already used in [dependencies].

UPD: It does not look like you use hex-literal outside of tests, so you probably should remove it from the [dependencies] section.

newpavlov · 2025-02-26T20:32:08Z

kupyna/Cargo.toml

+
+[package.metadata.docs.rs]
+all-features = true
+rustdoc-args = ["--cfg", "docsrs"]


We no longer need to set rustdoc-args since this configuration flag is passed by default by docs.rs build system.

newpavlov · 2025-02-26T20:33:50Z

kupyna/tests/mod.rs

+mod kup48;
+
+mod kup384;
+mod kup512;


This file is not needed. cargo test will automatically handle files in the tests folder.

newpavlov · 2025-02-26T20:34:38Z

kupyna/src/lib.rs

+}
+
+#[cfg(feature = "zeroize")]
+impl ZeroizeOnDrop for KupynaLongVarCore {}


Add an empty line at the end of each file.

newpavlov · 2025-02-26T20:35:45Z

kupyna/README.md

+
+Also, see the [examples section] in the RustCrypto/hashes readme.
+
+## Minimum Supported Rust Version


After MSRV bump to 1.85 you can remove this section since we will rely on the MSRV-aware resolver.

newpavlov · 2025-02-26T20:36:19Z

kupyna/README.md

+hasher.update(b"my message");
+let hash = hasher.finalize();
+
+println!("Computed Hash: {:02X?}", hash);


It's better to assert hash value here, see the examples in other crates for the reference.

kupyna/README.md

jkoudys · 2025-03-01T08:19:30Z

Thanks @newpavlov , I've opened AnarchistHoneybun#5 against the PR'd branch separately to address most of your comments. There are still a few failed cases on a cargo test to address, but for the most part it's looking very groestley and hopefully ready to join the RustCrypto hashes family soon.

side note: I built a GitHub codespace to run this in which I have working nicely. Is it worth including a devcontainer.json in the main branch so anybody can fork then run it in a codespace, or would we rather avoid needing to manage a config file and leave it .gitignored?

jkoudys · 2025-03-01T10:05:50Z

The 256-bit version's passing all its tests. The 512 has a few failures on larger message sizes, so I'm guessing there's still some error with the new padding code that's been implemented. I believe this was working correctly when it was a standalone lib. It's only struggling on larger data size.

running 6 tests
test kup512_n0 ... ok
test kup512_n1024 ... FAILED
test kup512_n1536 ... FAILED
test kup512_n2048 ... FAILED
test kup512_n512 ... ok
test kup512_n8 ... ok

Code review for Rust crypto main PR

Added no_std to the code

newpavlov · 2025-03-04T08:15:01Z

.gitignore

@@ -2,3 +2,4 @@ target/
 */target/
 */*/target/
 */Cargo.lock
+.devcontainer/


Remove this unnecessary addition (you probably should use a global .gitignore for stuff like this).

newpavlov · 2025-03-04T08:16:37Z

kupyna/Cargo.toml

+[dev-dependencies]
+digest = { version = "=0.11.0-pre.10", features = ["dev"] }
+hex-literal = "1"
+base16ct = { version = "0.2", features = ["alloc"] }


You don't use this dependency. Either remove it, or add an example:

// Hex-encode hash using https://docs.rs/base16ct let hex_hash = base16ct::lower::encode_string(&hash); assert_eq!(hex_hash, "5eb63bbbe01eeed093cb22bb8f5acdc3");

(the snippet is taken from md5)

newpavlov · 2025-03-04T08:18:39Z

kupyna/tests/kup48.rs

+    let input = hex!(
+        "000102030405060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F
+202122232425262728292A2B2C2D2E2F303132333435363738393A3B3C3D3E3F"
+    );


You can use multiple string literals with the hex! macro:

let input = hex!( "000102030405060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F" "202122232425262728292A2B2C2D2E2F303132333435363738393A3B3C3D3E3F" );

newpavlov · 2025-03-04T08:19:30Z

kupyna/tests/kup48.rs

+    assert_eq!(
+        result[..],
+        hex!("2F6631239875")[..],
+        "Kupyna-48 did not produce the expected hash output"


These assert messages can be removed.

qol for tests

newpavlov reviewed Oct 11, 2024

View reviewed changes

kupyna/Cargo.toml Outdated Show resolved Hide resolved

newpavlov reviewed Oct 12, 2024

View reviewed changes

kupyna/src/sub_units/t_xor_plus/tests/test_individual_layers.rs Outdated Show resolved Hide resolved

jkoudys and others added 22 commits October 14, 2024 00:02

Add kupyna as a new member

0db03dd

add a basic first-past cargo based on ascon's

2517c46

Add readme

d5532d8

update usage in readme

7e5766e

First pass, pushing up of @AnarchistHoneybun's matrix XORing code

2d01f22

fix: update correct crate name

bf41d89

Add kupyna to the list of algos

190b351

update algo link

9d2eada

update author creds for kupyna readme

2d0218e

updating toml

60ad1de

resolving clippy warnings/errors

d212a3f

rustfmt pass

36d271d

new gitignore

350e568

library updated to use a struct

1310735

renamed base level function kept for b/w compatibility

7b508cd

removed state size param from constructor to make dependent on the ha…

d9dc773

…sh code size

rustfmt pass

1bf9cad

added state mtrx col+row fields & num round field on hash struct

11c9b53

refactored to pass borrow of hasher struct to downstream functions

6346cff

passing borrow of struct further downstream to eliminate all constant…

96b4322

… dependencies

module refactored to pass borrow of struct around, eliminates need of…

6db4b7e

… the row and col constants

tests are broken now

97c31bf

AnarchistHoneybun added 8 commits February 24, 2025 22:16

short core compress + tests

b9516af

library code update to be groestl-esque

b8900fc

old file cleanup

fee8ad8

readme update

a059e0e

Merge remote-tracking branch 'upstream/master' into main_repo_contrib

0dc1882

# Conflicts: # README.md

sync

c87e493

Implement compression and transformation functions in compress1024 mo…

8ad2b1e

…dule

Add new test modules for kup384 and kup512

ec89c1b

newpavlov reviewed Feb 26, 2025

View reviewed changes

jkoudys added 5 commits March 1, 2025 07:44

Set kupyna edition to 2024 to match the others

4a5b9bd

Set kupyna edition to 2024 to match the others

7a5bfb3

Add an assert_eq example following the approach in groestl

7665c7f

Remove useless tests/mod.rs as it's auto-loaded

5287fdd

Newlines and formatting cleanup of kupyna

2a61861

jkoudys mentioned this pull request Mar 1, 2025

Code review for Rust crypto main PR AnarchistHoneybun/kupyna_hashes_contrib#5

Merged

Update .gitignore

d6f6de4

AnarchistHoneybun and others added 6 commits March 4, 2025 10:40

Merge pull request #5 from jkoudys/master-honeybun

f4eec74

Code review for Rust crypto main PR

fix: padding issues for larger state

632d748

dep update

3ab163f

fmt pass

9321a0d

no std added

b09b7d0

Merge pull request #6 from AnarchistHoneybun/no_std

5232e7f

Added no_std to the code

newpavlov reviewed Mar 4, 2025

View reviewed changes

AnarchistHoneybun and others added 3 commits March 4, 2025 23:32

update gitignore and encoding example

7172ec1

updated tests

233cb9e

Merge pull request #8 from AnarchistHoneybun/no_std

9e14592

qol for tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kupyna: implemented hashing function #621

Kupyna: implemented hashing function #621

AnarchistHoneybun commented Oct 11, 2024

AnarchistHoneybun commented Oct 11, 2024

AnarchistHoneybun commented Oct 11, 2024

newpavlov commented Oct 11, 2024

AnarchistHoneybun commented Oct 12, 2024

newpavlov commented Oct 12, 2024

AnarchistHoneybun commented Feb 26, 2025

newpavlov commented Feb 26, 2025 •

edited

Loading

newpavlov Feb 26, 2025 •

edited

Loading

newpavlov Feb 26, 2025

newpavlov Feb 26, 2025

newpavlov Feb 26, 2025

newpavlov Feb 26, 2025

newpavlov Feb 26, 2025

jkoudys commented Mar 1, 2025

jkoudys commented Mar 1, 2025

newpavlov Mar 4, 2025

newpavlov Mar 4, 2025

newpavlov Mar 4, 2025

newpavlov Mar 4, 2025


		Also, see the [examples section] in the RustCrypto/hashes readme.

		## Minimum Supported Rust Version

Kupyna: implemented hashing function #621

Are you sure you want to change the base?

Kupyna: implemented hashing function #621

Conversation

AnarchistHoneybun commented Oct 11, 2024

AnarchistHoneybun commented Oct 11, 2024

AnarchistHoneybun commented Oct 11, 2024

newpavlov commented Oct 11, 2024

AnarchistHoneybun commented Oct 12, 2024

newpavlov commented Oct 12, 2024

AnarchistHoneybun commented Feb 26, 2025

newpavlov commented Feb 26, 2025 • edited Loading

newpavlov Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkoudys commented Mar 1, 2025

jkoudys commented Mar 1, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

newpavlov commented Feb 26, 2025 •

edited

Loading

newpavlov Feb 26, 2025 •

edited

Loading