Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecdsa: bump rand_core from 0.6.4 to 0.9.0 #901

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ecdsa: bump rand_core from 0.6.4 to 0.9.0 #901

wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Feb 14, 2025 •
edited
Loading

@baloo baloo marked this pull request as draft February 14, 2025 23:53
@baloo baloo force-pushed the baloo/ecdsa/bump-rand-core branch from 508b358 to 6a07484 Compare February 14, 2025 23:54
@baloo baloo mentioned this pull request Feb 15, 2025
Merged
tarcieri pushed a commit to RustCrypto/traits that referenced this pull request Feb 15, 2025
@baloo
signature: Prehash should accept a TryCryptoRng (#1752)
684e9bc 
This is so that a `RandomizedDigestSigner` can call into
`hazmat::RandomizedPrehashSigner` directly with the provided rng.

Example use: RustCrypto/signatures#901
@baloo baloo force-pushed the baloo/ecdsa/bump-rand-core branch from c3f377d to 0633ed0 Compare February 15, 2025 05:12
baloo
baloo commented Feb 16, 2025
View reviewed changes
ecdsa/src/signing.rs
prehash: &[u8],
) -> Result<Signature<C>> {
let z = bits2field::<C>(prehash)?;
let mut ad = FieldBytes::<C>::default();
rng.fill_bytes(&mut ad);
rng.try_fill_bytes(&mut ad).map_err(|_| Error::new())?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#905 (comment)

Same situation here, we're eating the error from the Rng

This was referenced Feb 16, 2025
Open
Closed
@baloo baloo force-pushed the baloo/ecdsa/bump-rand-core branch from 0633ed0 to 8b8213b Compare February 20, 2025 17:13
@baloo baloo force-pushed the baloo/ecdsa/bump-rand-core branch from 8b8213b to 6f10d63 Compare February 20, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baloo