Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Remove Tortuga, Update Hive #1013

Merged
merged 2 commits into from
Jan 20, 2025
Merged

[Maps] Remove Tortuga, Update Hive #1013

merged 2 commits into from
Jan 20, 2025

Conversation

Roudenn
Copy link
Collaborator

@Roudenn Roudenn commented Jan 19, 2025

  • Тортуга удалена полностью по причине невозможности обновлять эту карту. Её планировка слишком кривая и игрокам эта карта совсем не нравится
  • Хайв обновлён (частично) для соответствия апстриму (не до конца пока что)

Summary by CodeRabbit

  • Удаление карты
    • Карта "Tortuga" была полностью удалена из игры
    • Больше не доступна для выбора и игры
    • Удалена из списка тестируемых карт и пула карт по умолчанию

@Roudenn Roudenn requested a review from Rxup as a code owner January 19, 2025 14:22
Copy link
Contributor

coderabbitai bot commented Jan 19, 2025

Walkthrough

В этом обновлении была полностью удалена конфигурация карты "Tortuga" из игровой системы. Изменения коснулись трех основных файлов: тестового файла интеграционных тестов, файла пула карт и самого файла конфигурации карты. Карта "BackmenTortuga" была полностью исключена из списка доступных игровых карт, что означает её полное удаление из игрового процесса.

Changes

Файл Изменения
Content.IntegrationTests/Tests/PostMapInitTest.cs Удалена запись "BackmenTortuga" из массива GameMaps
Resources/Prototypes/_Backmen/Maps/Pool/backmenstandart.yml Удалена карта BackmenTortuga из списка активных карт
Resources/Prototypes/_Backmen/Maps/backmen_tortuga.yml Полностью удален файл конфигурации карты

Poem

🏴‍☠️ Прощай, Тортуга, карта пиратская,
Твой путь окончен, судьба роковая!
В игровом мире больше не странствуешь,
Удален файл, как волною смываемый.
Прощай, матрос безмятежный! 🌊


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53ef47e and 5f13c04.

📒 Files selected for processing (3)
  • Content.IntegrationTests/Tests/PostMapInitTest.cs (0 hunks)
  • Resources/Prototypes/_Backmen/Maps/Pool/backmenstandart.yml (0 hunks)
  • Resources/Prototypes/_Backmen/Maps/backmen_tortuga.yml (0 hunks)
💤 Files with no reviewable changes (3)
  • Content.IntegrationTests/Tests/PostMapInitTest.cs
  • Resources/Prototypes/_Backmen/Maps/Pool/backmenstandart.yml
  • Resources/Prototypes/_Backmen/Maps/backmen_tortuga.yml
⏰ Context from checks skipped due to timeout of 300000ms (3)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: Test Packaging
  • GitHub Check: build (ubuntu-latest)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/XL S: Untriaged Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. and removed S: Untriaged labels Jan 19, 2025
@nomad0260 nomad0260 merged commit d366ab5 into Rxup:master Jan 20, 2025
16 checks passed
Rxup added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants