Enabled Some Suppressed Spectests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanLamansky
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Thanks for checking on these. I was saddened when they were broken in .NET 5 but haven't gone back to check to see if future .NETs fixed it!
I don't think the precise behaviors here are defined by Microsoft, so there's a chance they'll break again someday, but then we can just suppress it once more.
|
Would it be worth adding .NET9 to the CI? That way there's some warning ahead of the actual release if things are going to break. |
|
It would be a good experiment but I want the main branch to only have stable versions of things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some suppressed spectests which are no longer necessary (tested under dotnet 8.0).
I assume every single suppressed spectest in here indicates a bug in dornet-webassembly which needs to be fixed? If so I'll try to tackle some of these.