Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinch zoom for phones and fixes for item list grid view #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HiroDane
Copy link

🚀 Pull Request

Description:
A general quality of life update. Added pinch to zoom and pan for phones while reading manga. Works best with webtoon mode. Fixed bug where things were not properly routed to details page from List grid view.

Title:
Pinch Zoom for reading Manga and Fix routing from List Grid View

Summary of Changes:
FEATURE: Added pinch zoom feature using InteractiveViewer class for phones.
FIX: manga list items from grid view were not correctly routed to corresponding manga details pages on android.
FIX: List items from grid view were not routing at all on desktop.

Type of Changes:

  • Added optional "isManga" bool parameter to listItem and listItemDesktop widgets so that mangas and animes can be routed separately accordingly.
  • Wrapped _buildPageViewMode and _buildWebtoonMode with Interactive Viewer only for mobile platforms to implement pinch zooming for reading manga.

Testing Notes:
Tested on Windows 10 and Android 13

Submission Checklist:

  • I have read and followed the project's contributing guidelines
  • My code follows the code style of this project
  • I have tested the changes and ensured they do not break existing functionality
  • I have added or updated documentation as needed
  • I have linked related issues in the description above
  • I have tagged the appropriate reviewers for this pull request

FEATURE: Added pinch zoom feature using InteractiveViewer class for phones.
FIX: manga list items from grid view were not correctly routed to corresponding manga details pages on android.
FIX: List items were not routing at all on desktop.
Copy link
Contributor

🎉 Thank you for your contribution!

Your Pull Request has been successfully submitted and is now awaiting review. We truly appreciate your efforts to improve Anymex.

👥 Connect with the Community

While you're here, why not join our communities to stay engaged?

  • Discord: Chat with fellow developers, ask questions, and get the latest updates.
  • Telegram: Connect directly with us for real-time discussions and updates.

📋 What to Expect Next

  • Our team will review your pull request as soon as possible.
  • You'll receive notifications if further information or changes are needed.
  • Once approved, your changes will be merged into the main project.

We're excited to collaborate with you. Stay tuned for updates!

@Shebyyy Shebyyy requested a review from RyanYuuki January 23, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant