Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blur performance #116

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fixed blur performance #116

merged 1 commit into from
Feb 22, 2024

Conversation

ILOVEPIE
Copy link
Member

  • Made size of blur pass dynamic.
  • Moved positioning calculations to javascript.
  • Fixed shader caching.

This fixes #114

 * Made size of blur pass dynamic.
 * Moved positioning calculations to javascript.
 * Fixed shader caching.
@ILOVEPIE ILOVEPIE added the bug Something isn't working label Feb 21, 2024
@ILOVEPIE ILOVEPIE requested a review from StoneyEagle February 21, 2024 21:05
@ghost
Copy link

ghost commented Feb 21, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ILOVEPIE ILOVEPIE changed the title Fixed blur performance. Fixed blur performance Feb 21, 2024
@ILOVEPIE ILOVEPIE requested review from MarkJGx and Eveeifyeve and removed request for StoneyEagle and MarkJGx February 21, 2024 21:25
Copy link

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ILOVEPIE ILOVEPIE merged commit fe25fe7 into master Feb 22, 2024
2 checks passed
@ILOVEPIE ILOVEPIE deleted the blurPerformanceFix branch February 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\blur is slow due to texture size being too large.
2 participants