updating environment variables #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedelwolff
requested changes
Jul 23, 2024
docker-compose.yml
Outdated
| - DEBUG=True | ||
| - DB_HOST=db | ||
| - DB_PORT=5432 | ||
| - DB_NAME=term_db # see POSTGRES_DB above | ||
| - DB_USER=sadilar # see POSTGRES_USER above | ||
| - DB_PASSWORD=sadilar # see POSTGRES_PASSWORD above | ||
| - DB_PASSWORD=${DB_PASSWORD} |
There was a problem hiding this comment.
You deleted the comment that says "see POSTGRES_PASSWORD above". The point is to keep the two passwords synchronised. I propose you keep the comment, and see the section above that will require the same change.
- removed docker compose version not needed anymore - updated readme file
daniel-gray-tangent
force-pushed
the
feature/remove-key
branch
from
496b430 to
5d3cb14
Compare
friedelwolff
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.