Settings improvements #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by removing it.
The setting for SHOW_TOOLBAR_CALLBACK seems to have been an attempt
to work around issues when running inside docker. Debug toolbar tries
to handle this case, but it doesn't work sufficiently (at least in my
case). The documentation has an opinion on this matter:
Do not use
DEBUG_TOOLBAR_CONFIG = {"SHOW_TOOLBAR_CALLBACK": lambda request: DEBUG}
in your project’s settings.py file.
This commit is longer than I'd like, but the setting of INTERNAL_IPS
seems to really fix it, and solves the fact that the debug context
processor wasn't working either. With this fixed, {% debug %} works
in templates.
INTERNAL_IPS should best contain IP addresses rather than hostnames.
IS_RUNNING_TESTS... no idea why we would want the toolbar while
running tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.