Rework accounts #118
Merged
Rework accounts #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow easy form styling using bootstrap. This way we can render
forms with {{ form }} instead of having to manually handle each
field verbosely.
Entirely rework the accounts front-end to simplify things and align better with built-in Django: - Use Bootstrap infrastructure to render forms plainly in templates (see previous commit). - Rename forms and views to correspond to the builtin ones, but ensure that the builtin ones can't accidentally be imported. - Use a base template for all account-related pages to ensure consistency. - Reuse the exact wording in Django templates in more places to be able to reuse Django translations seamlessly. - Avoid duplicate URLs that can be confusing if you hit the wrong one.
Styling and indenting in the footer is slightly reworked, as the logout view has to be invoked with a POST. `hx-disable` is added in the cases where a full-page reload is required. With the admin link removed, the navbar now has more space for label expansion in other languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.