fix(a11y): more accessible breadcrumbs #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedelwolff
requested changes
Oct 3, 2024
This is based on [Bootstrap](https://getbootstrap.com/docs/4.0/components/breadcrumb/)'s example, and conforms to the WAI-ARIA Authoring Practices Guide for [breadcrumbs](https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/)
Restioson
force-pushed
the
fix/breadcrumb-a11y
branch
from
5cbe95d to
bd1a3ec
Compare
friedelwolff
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Bootstrap's example, and conforms to the WAI-ARIA Authoring Practices Guide for breadcrumbs. The separators are added via CSS in bootstrap. I decided to keep it with the default
/separator from Bootstrap (this is used in the WAI-ARIA example too), but happy to switch back to the previous>.The way this is read on my Android device in TalkBack is "Institutions - link one of two in list of two items. Slash two of two. (Institution name)"