chore(ci): set up Lighthouse auditing in CI #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setup is working now, pending some adjustments - failure is due to the site failing the audits. We can configure these as we'd like to. |
Restioson
force-pushed
the
ci/lighthouse
branch
6 times, most recently
from
e9c963f to
89cbcdc
Compare
Restioson
requested review from
friedelwolff and
jrb-s2c-github
as code owners
friedelwolff
requested changes
Oct 28, 2024
This enables its use in the LHCI script (see following commits)
These were triggering warnings due to using an outdated version of Node.js internally
For now, this just hits the main pages
Restioson
force-pushed
the
ci/lighthouse
branch
from
6fcb4f6 to
c1d4e9f
Compare
Adding data before running Lighthouse against the app ensures that we get better coverage of the HTML (some is only enabled when content is present).
Previously, this command would not work (`dev-mass-pdf-upload` was renamed to `import-documents`). This brings the name of the Makefile command back in line with the Django manage.py command.
This is necessary to get 100% coverage of the HTML on the documents page by Lighthouse
This is also better for Lighthouse coverage
Restioson
force-pushed
the
ci/lighthouse
branch
from
c1d4e9f to
918294e
Compare
This will run Lighthouse CI against the current app, with the current data stored in the DB.
friedelwolff
approved these changes
Oct 28, 2024
Restioson
force-pushed
the
ci/lighthouse
branch
from
394806f to
6ea1ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this just hits the main pages.
Todo
lhci autorun