Assorted dev experience & CI fixes #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by a variable that can be passed on the command line, e.g. `make test module=general.tests.test_document_admin`
Describe some common commands and patterns to ease development of LwimiLinks
This prevents them from breaking if we ever accidentally create files with their names in the root directory of the project (and is also just good practice). See https://www.gnu.org/software/make/manual/html_node/Special-Targets.html for more
These are very commonly used command verbs, so they are nice to as shortcuts, especially for people getting used to the project
We were not actually running the linter in CI (despite the name of the job saying so)
Restioson
requested review from
friedelwolff and
jrb-s2c-github
as code owners
Restioson
force-pushed
the
chore/misc-dx-fixes
branch
from
ae8a177 to
c18592b
Compare
|
I've verified that the CI does now properly fail for both linting issues and formatting issues (added some commits here and then force-pushed to remove) |
This was a linting failure from [zizmor](https://blog.yossarian.net/2024/10/27/Now-you-can-have-beautiful-clean-workflows). See actions/checkout#485 for more info on why this is a potential security issue.
|
The last commit probably doesn't affect us, but better to have it there in case we do one day add a sensitive GitHub token for use in login. I'm not sure if it may have an impact on the deployment workflow (this is the only one I am not sure how to test) |
friedelwolff
approved these changes
Nov 5, 2024
friedelwolff
reviewed
Nov 5, 2024
| @@ -125,6 +130,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
To help in my understanding: how does a later git fetch work if the credentials aren't there any more?
There was a problem hiding this comment.
I think it works because we only need public auth for the following fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes include:
make test(passmodule=...)lintandfmtaliases to Makefiletest_frontend.py