Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to styling and template #87

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

OnaMosimege
Copy link
Contributor

Add changes to styling and template according to new spec, and refactor css

@OnaMosimege OnaMosimege requested a review from friedelwolff as a code owner July 2, 2024 17:43
@OnaMosimege OnaMosimege force-pushed the feature/projects-page branch 2 times, most recently from 5b768b5 to daf87c7 Compare July 4, 2024 12:59
</select>
</div>
<div class="filter-label">
<label for="filter">{% trans "Filter:" %}</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no element with id="filter".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

<div class="form-group">
<label for="subject_select">{% trans "Subject" %}</label>
<select name="subject" class="form-control form-control-lg" id="subject_select">
<option value="">{% trans " All subjects" %}</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary space at the start of the string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

</div>
<div class="project-body">
<div class="card-text-description">
{{ project.description|truncatewords:30 }} <a href="{% url 'project_detail' project.project.id %}">Read more</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark "Read more" for translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@OnaMosimege OnaMosimege force-pushed the feature/projects-page branch from daf87c7 to 4024d26 Compare July 5, 2024 06:37
@OnaMosimege OnaMosimege merged commit fd85d90 into develop Jul 5, 2024
2 checks passed
@OnaMosimege OnaMosimege deleted the feature/projects-page branch July 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants