-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to styling and template #87
Conversation
5b768b5
to
daf87c7
Compare
app/templates/app/projects.html
Outdated
</select> | ||
</div> | ||
<div class="filter-label"> | ||
<label for="filter">{% trans "Filter:" %}</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no element with id="filter".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove
app/templates/app/projects.html
Outdated
<div class="form-group"> | ||
<label for="subject_select">{% trans "Subject" %}</label> | ||
<select name="subject" class="form-control form-control-lg" id="subject_select"> | ||
<option value="">{% trans " All subjects" %}</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unnecessary space at the start of the string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
app/templates/app/projects.html
Outdated
</div> | ||
<div class="project-body"> | ||
<div class="card-text-description"> | ||
{{ project.description|truncatewords:30 }} <a href="{% url 'project_detail' project.project.id %}">Read more</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mark "Read more" for translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
daf87c7
to
4024d26
Compare
Add changes to styling and template according to new spec, and refactor css