Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language page #99

Merged
merged 1 commit into from
Jul 24, 2024
Merged

language page #99

merged 1 commit into from
Jul 24, 2024

Conversation

OnaMosimege
Copy link
Contributor

add language page template, view, and styling

{% for item in language_data %}
<h5>{{ item.language.name }}</h5>
<div class="col-md-6 col-12 detail-col">
<p><strong>Documents</strong></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sub-heading, so please consider using an HTML heading, then no specific styling (like <strong>) is needed here. Above it jumped from h2 to h5. Maybe use them in order h1-h2-h3, unless that messes with your design.

Same thing below with Projects.

Please review all these headings to mark for translation as needed.

@OnaMosimege OnaMosimege force-pushed the feature/language-detail-page branch from 5d76d2e to c7f90bf Compare July 24, 2024 13:25
@OnaMosimege OnaMosimege merged commit cb1a749 into develop Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants