-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we validate against correct SPOClassUID
in pixl_dcmd
tests
#581
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 87.38% 87.29% -0.10%
==========================================
Files 76 76
Lines 3386 3362 -24
==========================================
- Hits 2959 2935 -24
Misses 427 427 ☔ View full report in Codecov by Sentry. |
projects/configs/tag-operations/test-extract-uclh-omop-cdm.yaml
Outdated
Show resolved
Hide resolved
otherwise system tests fail
otherwise instance is dropped due to unsupported modality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting and fixing Paul!
projects/configs/tag-operations/uclh-nasogastric-tube-project-ngt-only-full-dataset.yaml
Outdated
Show resolved
Hide resolved
…as it have been removed
…ay config and move duplicated tags into base
Description
Fixes #580
MODALITY_TO_CLASS_UID
dictionary topytest_pixl.dicom
module to map DICOM modality to SOPClassUIDtest_anonymise_and_validate_dicom
to ensure we validate against all modalities listed in all project configsbase.yaml
(otherwisetest_merge_base_only_tags
complains that tags are duplicated across config files)pixl_dcmd
tests (some tests were including fixtures that were not actually used / needed for the tests)vanilla_single_dicom_image_DX
tovanilla_dicom_image_DX
as the previousvanilla_dicom_image_DX
fixture has been removed as not neededType of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.squash and merge