Radial oat method

[ConnectedSystems]

Address #132

Radial OAT sampling and analysis method.
Includes Elementary Effects and Jansen's sensitivity estimation.

Still a work in progress and not ready for merge.

Requires:

• Additional testing and code review (by someone other than me)
• Clean up/additional docstrings
• CLI interface functions
• Tests for CI
• Example scripts

[willu47]

Hi @ConnectedSystems. Many thanks for this pull request which tackles issue #132

I've made some comments on syntax inline.

Is it worth adding this as a strategy within the Morris submodule? And do the analyze methods differ significantly from the existing implementations?

As you state, there's still a fair amount of work on implementing tests for these new modules. It may be worth parameterising existing tests for the morris method with the different methods. Ideally, they should all produce the same values.

Happy to iterate on this.

[ConnectedSystems]

I've made some comments on syntax inline.

Thanks - for some I'm obviously reliant on a linter which usually handles styling for me - it appears not to be working for me at the moment but have addressed these manually.

Is it worth adding this as a strategy within the Morris submodule?

I was going to ask about this. Wasn't sure how best cleanly incorporate it at first glance but will take a more in-depth look again tomorrow.

And do the analyze methods differ significantly from the existing implementations?

I think they differ enough to warrant separate implementations but happy to be corrected on this. I plan to have a closer examination when I have more time later on.

As you state, there's still a fair amount of work on implementing tests for these new modules. It may be worth parameterising existing tests for the morris method with the different methods. Ideally, they should all produce the same values.

The same values, as in, the results between Morris and Radial OAT should be identical?
From my initial testing, this is not the case but the rankings were the same.

[ConnectedSystems]

Still todo:

• Tests for CI
  • sequential use works as intended
  • sobol_jansen and sobol results should match
  • rank order of radial_ee and morris should at least match (I believe) if not the mu_star values
• CLI interface functions
• Example scripts

[ConnectedSystems]

Finalized tests and initial CLI support.

Still to do:

• Finalize example scripts for documentation, which will lead to final CLI support
• Clean up code where needed

[ConnectedSystems]

This PR ready for review

[lbteixeira]

Hi, @ConnectedSystems.

In #320 you mentioned this topic, and I could help if you need. Do you have a more or less working code? Or perhaps I could start from scratch?

[ConnectedSystems]

Hi @lbteixeira

This specific implementation is working. If you care to take a look you can check out the branch in my repository.
The branch name is radial-oat-method (https://github.com/ConnectedSystems/SALib/tree/radial-oat-method).

What would be nice is to make this compatible with the Morris strategy class

I have not looked into this in detail so I am not sure if the data structures are compatible and if not, what would be required to make them compatible.

While it would be nice to merge things, I also don't want you to spend too much time on this.