Forbid hashed tables in AFF #386
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to forbid hashed tables, because we do not see any advantage in the AFF. If later there will be use cases, we can remove this limitation.
|
Wondering, perhaps go as far as having everything SORTED TABLE |
| @@ -65,6 +65,8 @@ Each JSON Schema provided in this repository is automatically generated. For thi | |||
|
|
|||
| The ABAP types are self-contained, so it is possible to work on them in any system (e.g., in an SAP BTP, ABAP environment system). | |||
|
|
|||
| Instead of hashed tables, please use sorted tables with a defined key. | |||
There was a problem hiding this comment.
I am wondering whether we should add the information to the sub chapter "Type Mapping" below?
There we could also enhance the table. What do you think?
There was a problem hiding this comment.
I enhanced the table. See my newest commit. Please rereview
Let's start/continue discussion in #176 |
schneidermic0
requested changes
Aug 5, 2022
Co-authored-by: Michael Schneider <[email protected]>
huber-nicolas
commented
Aug 5, 2022
schneidermic0
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to forbid hashed tables, because we do not see any advantage in the AFF. If later there will be use cases, we can remove this limitation.
This is a proposal for issue #176