-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDOT] Add new object EDOT #682
Open
i506210
wants to merge
17
commits into
SAP:main
Choose a base branch
from
i506210:feature/edot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a8ec8b7
Add files for EDOI & EDOT
i506210 499d83a
React to abaplint
i506210 e1e96b2
React to abaplint
i506210 ecdefa0
Merge branch 'main' into feature/edoi
i506210 3a2e9b9
React to comments from Michael Schneider
i506210 a1ec907
[EDOT] Add files for EDOT
i506210 6ed5d4c
reaction to comments
i506210 4c96d92
delete other object files in PR
i506210 a7025f3
correction
i506210 bdd762a
corrections
i506210 8848e73
Merge branch 'main' into feature/edot
i506210 1c07f07
Remove .DS_Store files
i506210 777533b
corrections
i506210 683a98d
corrections
i506210 6838a10
correction
i506210 ec64a94
correction
i506210 91e81a1
Merge branch 'main' into feature/edot
i506210 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# EDOT File Format | ||
|
||
File | Cardinality | Definition | Schema | Example | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,163 @@ | ||
{ | ||
"$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json", | ||
"title": "eDocument Type", | ||
"description": "eDocument type", | ||
"type": "object", | ||
"properties": { | ||
"formatVersion": { | ||
"title": "Format Version", | ||
"description": "Format version", | ||
"type": "string", | ||
"const": "1" | ||
}, | ||
"header": { | ||
"title": "Header", | ||
"description": "Header", | ||
"type": "object", | ||
"properties": { | ||
"description": { | ||
"type": "string", | ||
"maxLength": 30 | ||
}, | ||
"originalLanguage": { | ||
"title": "Original Language", | ||
"description": "Original language of the ABAP object", | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"abapLanguageVersion": { | ||
"title": "ABAP Language Version", | ||
"description": "ABAP language version", | ||
"type": "string", | ||
"enum": [ | ||
"standard", | ||
"cloudDevelopment" | ||
], | ||
"enumTitles": [ | ||
"Standard", | ||
"ABAP Cloud Development" | ||
], | ||
"enumDescriptions": [ | ||
"Standard", | ||
"ABAP cloud development" | ||
], | ||
"default": "standard" | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"description", | ||
"originalLanguage" | ||
] | ||
}, | ||
"generalInformation": { | ||
"title": "General Information", | ||
"description": "General information", | ||
"type": "object", | ||
"properties": { | ||
"tableName": { | ||
"title": "eDocument Table Name", | ||
"description": "eDocument table name", | ||
"type": "string", | ||
"maxLength": 30 | ||
}, | ||
"contingency": { | ||
"title": "Created in Contingency Mode", | ||
"description": "Created in contingency mode", | ||
"type": "boolean" | ||
}, | ||
"contingencyType": { | ||
"title": "eDocument Type Created Using Contingency", | ||
"description": "eDocument type created using contingency", | ||
"type": "string", | ||
"maxLength": 10 | ||
}, | ||
"archivePrepReq": { | ||
"title": "Preprocess Before Archiving", | ||
"description": "Preprocess before archiving", | ||
"type": "boolean" | ||
}, | ||
"edocumentSralConfiguration": { | ||
"title": "Additional Selection Fields", | ||
"description": "Additional selection fields of validation report", | ||
"type": "array", | ||
"uniqueItems": true, | ||
"items": { | ||
"title": "SRAL Configuration Type", | ||
"description": "SRAL configuration type", | ||
"type": "object", | ||
"properties": { | ||
"fileType": { | ||
"title": "File Type", | ||
"description": "File type", | ||
"type": "string", | ||
"maxLength": 10 | ||
}, | ||
"fileStructure": { | ||
"title": "File Structure Type", | ||
"description": "File structure type", | ||
"type": "string", | ||
"maxLength": 30 | ||
}, | ||
"fileDescription": { | ||
"title": "File Description", | ||
"description": "File description", | ||
"type": "string", | ||
"maxLength": 60 | ||
}, | ||
"isCloudRelevant": { | ||
"title": "File Cloud Relevancy", | ||
"description": "File cloud relevancy type", | ||
"type": "boolean" | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"fileType", | ||
"fileStructure" | ||
] | ||
} | ||
}, | ||
"edocSpecAdditionalTable": { | ||
"title": "eDocument Type Specific Additional Tables", | ||
"description": "eDocument type specific additional tables", | ||
"type": "array", | ||
"uniqueItems": true, | ||
"items": { | ||
"title": "eDocument Type Specific Additional Tables", | ||
"description": "eDocument type specific additional tables", | ||
"type": "object", | ||
"properties": { | ||
"sequenceNumber": { | ||
"title": "Sequence Number", | ||
"description": "Sequence number", | ||
"type": "string", | ||
"maxLength": 10 | ||
}, | ||
"tableName": { | ||
"title": "Table Name", | ||
"description": "Table name", | ||
"type": "string", | ||
"maxLength": 30 | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"sequenceNumber", | ||
"tableName" | ||
] | ||
} | ||
} | ||
}, | ||
"additionalProperties": false | ||
} | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"formatVersion", | ||
"header", | ||
"generalInformation" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,97 @@ | ||||||
"! <p class="shorttext synchronized" lang="en">eDocument Type</p> | ||||||
"! eDocument types that can be used in eInvoice process | ||||||
INTERFACE zif_aff_edot_v1 PUBLIC. | ||||||
|
||||||
TYPES: | ||||||
"! <p class="shorttext">SRAL Configuration Type</p> | ||||||
"! SRAL configuration type | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
BEGIN OF ty_sral_configuration, | ||||||
"! <p class="shorttext">File Type</p> | ||||||
"! File type | ||||||
"! $required | ||||||
file_type TYPE c LENGTH 10, | ||||||
"! <p class="shorttext">File Structure Type</p> | ||||||
"! File structure type | ||||||
"! $required | ||||||
file_structure TYPE c LENGTH 30, | ||||||
"! <p class="shorttext">File Description</p> | ||||||
"! File description | ||||||
file_description TYPE c LENGTH 60, | ||||||
"! <p class="shorttext">File Cloud Relevancy</p> | ||||||
"! File cloud relevancy type | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
is_cloud_relevant TYPE abap_bool, | ||||||
END OF ty_sral_configuration. | ||||||
"! <p class="shorttext">SRAL Configuration</p> | ||||||
"! SRAL configuration | ||||||
TYPES ty_sral_configurations TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. | ||||||
|
||||||
TYPES: | ||||||
"! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||||||
"! eDocument type specific additional tables | ||||||
BEGIN OF ty_additional_table, | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
"! <p class="shorttext">Sequence Number</p> | ||||||
"! Sequence number | ||||||
"! $required | ||||||
sequence_number TYPE c LENGTH 10, | ||||||
"! <p class="shorttext">Table Name</p> | ||||||
"! Table name | ||||||
"! $required | ||||||
table_name TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
END OF ty_additional_table. | ||||||
"! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||||||
"! eDocument type specific additional tables | ||||||
TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number. | ||||||
|
||||||
TYPES: | ||||||
"! <p class="shorttext">General Information</p> | ||||||
"! General information | ||||||
BEGIN OF ty_edoc_information, | ||||||
"! <p class="shorttext">eDocument Table Name</p> | ||||||
"! eDocument table name | ||||||
table_name TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
"! <p class="shorttext">Created in Contingency Mode</p> | ||||||
"! Created in contingency mode | ||||||
contingency TYPE abap_bool, | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
"! <p class="shorttext">eDocument Type Created Using Contingency</p> | ||||||
"! eDocument type created using contingency | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
i506210 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
contingency_type TYPE c LENGTH 10, | ||||||
"! <p class="shorttext">Preprocess Before Archiving</p> | ||||||
"! Preprocess before archiving | ||||||
archive_prep_req TYPE abap_bool, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. corrected |
||||||
"! <p class="shorttext">Additional Selection Fields</p> | ||||||
"! Additional selection fields of validation report | ||||||
edocument_sral_configuration TYPE ty_sral_configurations, | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
"! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||||||
"! eDocument type specific additional tables | ||||||
edoc_spec_additional_table TYPE ty_additional_tables, | ||||||
END OF ty_edoc_information. | ||||||
TYPES: | ||||||
"! <p class="shorttext">Header</p> | ||||||
"! The header for an ABAP main object (without source code) with a description of 30 characters (no key user) | ||||||
BEGIN OF ty_header_30_cloud, | ||||||
"! $required | ||||||
description TYPE c LENGTH 30, | ||||||
"! $required | ||||||
original_language TYPE zif_aff_types_v1=>ty_original_language, | ||||||
abap_language_version TYPE zif_aff_types_v1=>ty_abap_language_version_cloud, | ||||||
END OF ty_header_30_cloud. | ||||||
|
||||||
TYPES: | ||||||
"! <p class="shorttext">eDocument Type</p> | ||||||
"! eDocument type | ||||||
BEGIN OF ty_main, | ||||||
"! <p class="shorttext">Format Version</p> | ||||||
"! Format version | ||||||
"! $required | ||||||
format_version TYPE zif_aff_types_v1=>ty_format_version, | ||||||
"! <p class="shorttext">Header</p> | ||||||
"! Header | ||||||
"! $required | ||||||
header TYPE ty_header_30_cloud, | ||||||
"! <p class="shorttext">General Information</p> | ||||||
"! General information | ||||||
"! $required | ||||||
general_information TYPE ty_edoc_information, | ||||||
|
||||||
END OF ty_main. | ||||||
ENDINTERFACE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"formatVersion": "1", | ||
"header": { | ||
"description": "eDocument Type", | ||
"originalLanguage": "en" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having an example would also help me for the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I am unable to generate example, I created class and Transformation but its not clear to me in the report what object to be mentioned as input.