-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor library code templates #3147
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
requested changes
Feb 5, 2021
- moved modified code back to ES5 - double-checked usage of api v2 methods for renderer-scope code
There is some more work todo on the documentation here. We will need to review it carefully, but in general, it is important to get that re-newed. |
Will be covered in backlog item CPOUI5FRAMEWORK-551 |
Sorry for not responding earlier. The team already refactored the code templates with a3a8f82. Thanks a lot for your efforts @vobu @wridgeu @matz3 and @petermuessig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during a hackathon with @wridgeu @matz3 and @petermuessig, we discovered the somewhat outdated code examples that get revamped with this PR