feat(binding): Detect more globals in property- and aggregation bindings #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
expand-binding-checks
branch
from
890665f to
75160ef
Compare
* Embedded bindings might have multiple formatters * Use UI5 Logger in ExpressionParser
RandomByte
force-pushed
the
expand-binding-checks
branch
from
25384df to
a6a2cfc
Compare
In UI5 linter, the ExpressionParser currently can't make an educated call whether a variable is a global or not
RandomByte
force-pushed
the
expand-binding-checks
branch
from
e6a1643 to
937c52b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.