Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formatter): Remove duplicate findings #514

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix(formatter): Remove duplicate findings #514

merged 2 commits into from
Feb 14, 2025

Conversation

maxreichmann
Copy link
Member

@maxreichmann maxreichmann commented Feb 3, 2025 •
edited by matz3
Loading

  • fix(formatter): Remove duplicate findings
  • docs(Rules.md): Add explanation for unsupported-api-usage (new rule introduced by previous formatter change)

@maxreichmann maxreichmann changed the title fix(formatter): Remove duplicate findings fix(JS/TS BindingStrings): Improve linter findings Feb 3, 2025
@maxreichmann maxreichmann marked this pull request as ready for review February 3, 2025 15:49
@maxreichmann maxreichmann requested a review from a team February 3, 2025 15:49
@maxreichmann maxreichmann force-pushed the refactor-formatter-linting-message branch from 6dba2a0 to 658be06 Compare February 4, 2025 09:43
@maxreichmann maxreichmann requested a review from a team February 4, 2025 10:05
flovogt
flovogt reviewed Feb 5, 2025
View reviewed changes
KlattG
KlattG previously requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write it slightly differently and mention the formatter check as an example (use case).

matz3
matz3 previously approved these changes Feb 10, 2025
View reviewed changes
@matz3 matz3 dismissed KlattG’s stale review February 10, 2025 08:42

suggested changes have been applied

@maxreichmann maxreichmann requested a review from flovogt February 11, 2025 09:33
@matz3 matz3 force-pushed the refactor-formatter-linting-message branch from 2c340cb to 154eb71 Compare February 14, 2025 11:28
@matz3 matz3 force-pushed the refactor-formatter-linting-message branch from 154eb71 to 41d4c9c Compare February 14, 2025 11:29
@matz3 matz3 changed the title fix(JS/TS BindingStrings): Improve linter findings fix(formatter): Remove duplicate findings Feb 14, 2025
@matz3 matz3 requested a review from d3xter666 February 14, 2025 11:31
@matz3 matz3 merged commit 9306d8a into main Feb 14, 2025
15 checks passed
@matz3 matz3 deleted the refactor-formatter-linting-message branch February 14, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG left review comments

@d3xter666 d3xter666 d3xter666 approved these changes

@matz3 matz3 matz3 left review comments

@flovogt flovogt Awaiting requested review from flovogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxreichmann @matz3 @d3xter666 @flovogt @KlattG