Skip to content

[Dynamic page]: Height is set to 0 #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
dbadura opened this issue Apr 11, 2025 · 3 comments · May be fixed by #11325
Open
1 task done

[Dynamic page]: Height is set to 0 #11309

dbadura opened this issue Apr 11, 2025 · 3 comments · May be fixed by #11325
Assignees
@NakataCode
Labels
author action bug This issue is a bug in the code High Prio Kyma TOPIC P

Comments

@dbadura
Copy link

dbadura commented Apr 11, 2025

Bug Description

When using Dynamic page the height of inner components are set to 0. Width is inherited correctly.
This change c2c3608#diff-a5fe4f917c905d6488167ea63ca743eb54ef49097953a865162d21e78198fab4R15 introduced container-type:size which broke our page layout.
The workaround is to set height to viewport, hardcoded pixels, but we can't use it because our value has to be dynamic.

Affected Component

Dynamic Page

Expected Behaviour

Dynamic Page correctly set height.

Isolated Example

No response

Steps to Reproduce

Follow instruction from this issue: kyma-project/busola#3812

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.8

Browser

Firefox, Chrome

Operating System

Linux, MacOS

Additional Context

No response

Organization

Kyma

Declaration

  • I’m not disclosing any internal or sensitive information.
@dbadura dbadura added the bug This issue is a bug in the code label Apr 11, 2025
@dbadura dbadura changed the title [Dynamic page ]: Height is set to 0 [Dynamic page]: Height is set to 0 Apr 11, 2025
@plamenivanov91
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p ,

Could you please look into that regression?

Is this expected?

The instructions are in the initial description.

Regards,
Plamen Ivanov

@nnaydenow nnaydenow added the Kyma label Apr 14, 2025
@NakataCode NakataCode self-assigned this Apr 14, 2025
@NakataCode NakataCode moved this from Issues to In Progress in Maintenance - Topic P Apr 14, 2025
@NakataCode
Copy link
Contributor

Hello colleagues,

I've looked at the issue and it's not expected behavior. The problem, as you identified, is caused by the addition of container-type: size;, which breaks height inheritance. I've prepared a fix that changes it to container-type: inline-size; to restore proper height behavior while maintaining width-based container queries.

Best regards,
Nikola

@NakataCode NakataCode linked a pull request Apr 14, 2025 that will close this issue
Open
@dbadura dbadura mentioned this issue Apr 15, 2025
Open
@NakataCode
Copy link
Contributor

NakataCode commented Apr 17, 2025 •
edited
Loading

Hi @dbadura,

I wanted to ask if there is a live version of the Busola Web Components example where we can quickly verify the fix in context? I’ve been trying to reproduce the issue via kyma-project/busola#3812, but the setup requires cluster configuration and custom extension activation.

A deployed demo (or even a hosted version of the current broken state) would help confirm the layout fix and avoid any setup mismatches.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NakataCode NakataCode

Labels
author action bug This issue is a bug in the code High Prio Kyma TOPIC P
Projects
Maintenance - Topic P
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-dynamic-page): change the container-type SAP/ui5-webcomponents
4 participants
@plamenivanov91 @nnaydenow @dbadura @NakataCode