Skip to content

fix(ui5-dynamic-page): change the container-type #11325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NakataCode
Copy link
Contributor

Problem:

  • The current implementation uses 'container-type: size' which applies containment
    to both width and height dimensions. This creates a problem when combined with
    'height: inherit' as it disrupts the height inheritance chain, causing inner
    components to collapse to zero height while width continues to work correctly.

Solution:

  • By changing to 'container-type: inline-size', we maintain containment only for
    the inline (width) dimension while allowing height to behave normally. This
    preserves all width-based container queries used for responsive design while
    fixing the height inheritance issue.

Fixes: #11309

@NakataCode NakataCode marked this pull request as ready for review April 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dynamic page]: Height is set to 0
1 participant