Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-table): improve default column widths #11078

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

DonkeyCo
Copy link
Member

@DonkeyCo DonkeyCo commented Mar 12, 2025

Instead of using auto as default width, the table columns will default to 1fr. This allows table columns to equally take the available space.
This ensures the column's default width does not depend on the column content, leading to a more stable experience.

Additional changes:

  1. remove max-width
  2. defaults: width=undefined (use 1fr internally), min-width: 3rem
  3. remove left, right border of row according to design spec
  4. add "empty/dummy" space according to design spec
  5. adjust padding-left of first column/cell

Fixes #10536
Fixes #11051
Partially fixes #10716

Copy link
Contributor

@aborjinik aborjinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I said we should not try to be smart with the column templates but this continues in this change.
what i expect is having a single width property(1fr by default) for the column, no min/max width and cells have the min-width: 3rem in their css. we document that the cell should not be less than 3rem. With the width property of the column they can make it smaller than 3rem but this is not our problem anymore.

lets discuss on monday again.

@DonkeyCo DonkeyCo requested a review from KvM2 March 21, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants