-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-li): add text wrapping support #11108
Open
kgogov
wants to merge
14
commits into
main
Choose a base branch
from
feat-list-wrapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fda8e34
feat(ui5-li): add text wrapping support with expandable text
kgogov c16a504
feat(ui5-li): change wrappingType property to public
kgogov d68749c
chore(ui5-list): minor improvements to ListItemStandardTemplate
kgogov 5b43fa1
fix(ui5-li): reuse the already defined resize handler
kgogov 003b390
fix(ui5-li): correct property definition
kgogov f7ff2a5
chore(ui5-li): remove some unnecessary non-related changes
kgogov fa9dc15
fix(ui5-li): improve _maxCharacters getter
kgogov 04d2750
fix(ui-li): enable exportparts
kgogov 392cd28
fix(ui5-li): correct type declaration
kgogov c980712
chore: correct website type definition rendering
kgogov cef1a2a
chore: correct wrapping behavior sample
kgogov b9c3777
fix(ui5-li): improve CSS overstyling for list items
kgogov fb173da
fix(ui5-li): remove doulbe resize handler attachment
kgogov 2a8cc13
feat(ui5-li): add wrappable text templates with shared type definitions
kgogov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import List from "../../src/List.js"; | ||
import ListItemStandard from "../../src/ListItemStandard.js"; | ||
|
||
describe("List Mobile Tests", () => { | ||
before(() => { | ||
cy.ui5SimulateDevice("phone"); | ||
}); | ||
|
||
it("adjusts maxCharacters based on viewport size for wrapping list items", () => { | ||
const longText = "This is a very long text that exceeds 100 characters but is less than 300 characters. This sentence is just to add more text to ensure we pass the 100 character threshold. And now we're adding even more text to be extra certain."; | ||
|
||
cy.mount( | ||
<List> | ||
<ListItemStandard id="wrapping-item" wrappingType="Normal" text={longText}></ListItemStandard> | ||
</List> | ||
); | ||
|
||
// Get the list item and check its media range | ||
cy.get("#wrapping-item") | ||
.invoke('prop', 'mediaRange') | ||
.should('eq', 'S'); | ||
|
||
// Check that ExpandableText is created with maxCharacters prop of 100 | ||
cy.get("#wrapping-item") | ||
.shadow() | ||
.find("ui5-expandable-text") | ||
.first() | ||
.invoke('prop', 'maxCharacters') | ||
.should('eq', 100); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to be preloaded the user will have to import it, so we must create a file ListItemStandardExpandableText.ts next to the template. For reference, check the
ColorPaletteMoreColors.ts
and all the places it is mentioned (docs, component-import.js)