Skip to content

fix(ui5-button): adjust tooltips display #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(ui5-button): adjust tooltips display #11268

wants to merge 5 commits into from

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Apr 4, 2025

Issue:

  • The default icon tooltip is displayed over the ui5-button even though there is a text
    in the ui5-button's slot.

Solution:

  • The default icon tooltip should only be shown when the ui5-button is in icon-only mode
    according to the UX guidelines.

Fixes: #10824

@unazko unazko marked this pull request as ready for review April 7, 2025 10:21
@unazko unazko requested a review from didip1000 April 14, 2025 07:15
didip1000
didip1000 reviewed Apr 14, 2025
View reviewed changes
@unazko unazko requested a review from didip1000 April 16, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didip1000 didip1000 Awaiting requested review from didip1000

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF_ACC][ui5-toolbar-button]: show unexpected tooltip for some icon button
2 participants
@unazko @didip1000