fix(ui5-side-navigation): fix disabled and tooltips #11333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In collapsed Side Navigation when hover on disabled item the hover effect is not applied - Tooltips (if set) are visible for all items: parent, group, children, in menu, in sub menu - Tooltip for expand/collapse arrow added - Test page enhanced with different texts for the items JIRA: BGSOFUIRODOPI-3443
Stoev
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Please consider tentative suggestions:
fix(ui5-side-navigation): fix disabled items and tooltips
OR fix hover/focus states and tooltips
- In collapsed
SideNavigationdisabled items (ui5-sn-item-disabled) are excluded from hover/focus interactions. - Tooltips (if set) are visible for all items: parent, group, children, in menu, in submenu.
- Tooltip for expand/collapse arrow added.
- Updated test pages to reflect new tooltips, dynamic behaviors, and text truncation.
- ARIA attributes added to icons and elements for assistive technologies.
| @@ -45,7 +45,9 @@ class SideNavigationItemBase extends UI5Element implements ITabbable { | |||
| /** | |||
| * Defines the tooltip of the component. | |||
| * | |||
| * A tooltip attribute should be provided, in order to represent meaning/function, when the component is collapsed(icon only is visualized). | |||
| * A tooltip attribute should be provided, in order to represent meaning/function, | |||
| * when the component is collapsed (icon only is visualized) or the item text is truncated. | |||
There was a problem hiding this comment.
Please consider:
(showing only the icon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3443