docs(ui5-shellbar): adjust samples to UXC guidelines #11340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
changed the title
dobrinyonkov
force-pushed
the
shellbar-samples-uxc-adjust
branch
from
a8b3d5e to
8874d89
Compare
dobrinyonkov
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ShellBar samples to align with the new UXC guidelines by replacing deprecated APIs and improving the sample components.
- Updated basic samples to use the new ui5-shellbar-search component for search functionality.
- Removed deprecated attributes and components in advanced samples and replaced them with the new user menu components.
- Updated corresponding main.js files to import new components and handle search scopes accordingly.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/website/docs/_samples/fiori/ShellBar/Basic/sample.html | Replaced ui5-input with ui5-shellbar-search to update the search field API. |
| packages/website/docs/_samples/fiori/ShellBar/Basic/main.js | Imported ui5-shellbar-search to support the updated basic sample. |
| packages/website/docs/_samples/fiori/ShellBar/Advanced/sample.html | Removed deprecated attributes and updated the search field and user menu integration. |
| packages/website/docs/_samples/fiori/ShellBar/Advanced/main.js | Removed deprecated imports and added new ones, including handling dynamic search scope changes. |
| <ui5-user-menu-item icon="action-settings" text="Setting" data-id="setting"></ui5-user-menu-item> | ||
| <ui5-user-menu-item icon="official-service" text="Legal Information"> | ||
| <ui5-user-menu-item text="Terms of Use" data-id="terms-of-use"></ui5-user-menu-item> | ||
| <ui5-user-menu-item text="Private Policy" data-id="privacy-policy"></ui5-user-menu-item> |
There was a problem hiding this comment.
Consider renaming "Private Policy" to "Privacy Policy" to align with standard terminology.
Suggested change
| <ui5-user-menu-item text="Private Policy" data-id="privacy-policy"></ui5-user-menu-item> | |
| <ui5-user-menu-item text="Privacy Policy" data-id="privacy-policy"></ui5-user-menu-item> |
Copilot uses AI. Check for mistakes.
Comment on lines
+69
to
+71
| item.remove(); | ||
| }); |
There was a problem hiding this comment.
[nitpick] Consider using a more efficient method such as setting searchScope.innerHTML to an empty string if supported, to remove all search items and improve maintainability.
Suggested change
| searchScope.items.forEach(item => { | |
| item.remove(); | |
| }); | |
| searchScope.innerHTML = ""; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Shellbar samples to follow UXC guidelines. Removed APIs that will be deprecated.