fix(ui5-side-navigation): correct divider line position in RTL #11441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng position in RTL
|
You need to check if the selector is broken somehow. The idea of logical css props is to not use these rtl parameters. |
duygu-rmdn
requested review from
TeodorTaushanov
and removed request for
a team and
LidiyaGeorgieva
TeodorTaushanov
requested changes
May 2, 2025
kgogov
approved these changes
May 7, 2025
TeodorTaushanov
approved these changes
May 8, 2025
|
🎉 This PR is included in version v2.11.0-rc.0 🎉 The release is available on v2.11.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11433
Shift the RTL mode transformation from the SVG element of ui5-icon to the SVG group, ensuring that border-inline-start is accurate in RTL mode.