Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#344] API URL 변경 #345

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[#344] API URL 변경 #345

merged 1 commit into from
Apr 13, 2024

Conversation

Bumang-Cyber
Copy link
Contributor

@Bumang-Cyber Bumang-Cyber commented Apr 13, 2024

Issue Number

close #344

⛳️ Task

  • 화이팅하기

✍️ Note

  1. BASE_URL 처리
export const BASE_URL = "https://3.35.83.30.nip.io"; // 에서
export const BASE_URL = "https://43.200.52.7.nip.io"; // 로 바꿨습니다.
  1. BASE_URL 처리
    일부 로그인/패스워드 인증 관련 부분에 하드코딩된 부분이 url바꿀때마다 계속 오작동하는거 같아서 constant로 만들어 관리하도록 만들었습니다.

예시:

        response.url() === "https://3.34.147.187.nip.io/v1/members/email" &&
        response.url() === `${BASE_URL}${END_POINTS.EMAIL}` &&

@Bumang-Cyber Bumang-Cyber self-assigned this Apr 13, 2024
Copy link

Visit the preview URL for this PR (updated for commit fd082fa):

https://percenthotel--pr345-feat-344-url-zaer163h.web.app

(expires Sat, 20 Apr 2024 10:05:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5f3aee9d8d8535dbb552ad12361bc813c5a90573

@Bumang-Cyber Bumang-Cyber merged commit 5dc0018 into main Apr 13, 2024
2 of 3 checks passed
@Bumang-Cyber Bumang-Cyber deleted the feat/#344-url branch April 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseUrl 교체 및 로그인 로직에서 BaseUrl 하드코딩 되어 있는 부분 교체
1 participant