UI: display 'no data' if backend returns none in home page #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ErnestaP
commented
Nov 28, 2023
ErnestaP
commented
- ref: When the user's request is throttled, main page crashes cern-sis/issues-scoap3#247
drjova
reviewed
Nov 28, 2023
ui/package.json
Outdated
| @@ -11,6 +11,7 @@ | |||
| "dependencies": { | |||
| "@ant-design/cssinjs": "^1.17.2", | |||
| "antd": "^5.10.1", | |||
| "lodash": "^4.17.21", | |||
There was a problem hiding this comment.
why do we need lodash, I don't see using it in the PR :)
drjova
reviewed
Nov 28, 2023
ui/src/pages/index.tsx
Outdated
| @@ -63,8 +72,9 @@ export const getServerSideProps: GetServerSideProps = async () => { | |||
|
|
|||
| const res = await fetch(`${getApiUrl() + getSearchUrl(query)}`, authToken); | |||
| const { count, facets } = (await res?.json()) as Response; | |||
|
|
|||
| return { props: { count, facets, query } }; | |||
| const countValue = { count: count ? count : 0 }; | |||
There was a problem hiding this comment.
Suggested change
| const countValue = { count: count ? count : 0 }; | |
| const countValue = { count: count || 0 }; |
drjova
reviewed
Nov 28, 2023
ui/src/pages/index.tsx
Outdated
|
|
||
| return { props: { count, facets, query } }; | ||
| const countValue = { count: count ? count : 0 }; | ||
| const facetsValue = { facets: facets ? facets : null }; |
ErnestaP
force-pushed
the
back-history
branch
from
81729f6 to
d120a3e
Compare
ErnestaP
force-pushed
the
back-history
branch
from
d120a3e to
743a296
Compare
karolina-siemieniuk-morawska
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.