Affiliation compliance flag #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ErnestaP
commented
Feb 20, 2024
ErnestaP
commented
- compliance: flag on incomplete author cern-sis/issues-scoap3#295
pamfilos
reviewed
Feb 21, 2024
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( |
There was a problem hiding this comment.
remove the newly added migrations (14, 15) and run makemigration again, so there is only one file
ErnestaP
force-pushed
the
compliance-flag
branch
from
edc4796 to
8ddf4e0
Compare
pamfilos
requested changes
Feb 21, 2024
scoap3/articles/tasks.py
Outdated
| @@ -122,6 +124,20 @@ def check_doi_registration_time(obj): | |||
| return False, "DOI not found in our system." | |||
|
|
|||
|
|
|||
| def check_authors_affiliation(article_id): | |||
There was a problem hiding this comment.
why pass article_id if you need to fetch whole article object, already there
scoap3/articles/tasks.py
Outdated
| def check_authors_affiliation(article_id): | ||
| try: | ||
| article = Article.objects.get(id=article_id) | ||
| authors = Author.objects.filter(article_id=article) |
There was a problem hiding this comment.
or why you need article if you want to filter by article_id, please clean up
scoap3/articles/tasks.py
Outdated
| if len(affiliations) < 1: | ||
| return False, "Author does not have affiliations" | ||
| return True, "Authors' affiliations are compliant" | ||
| except Article.DoesNotExist: |
There was a problem hiding this comment.
we shoudnt need Article.DoesNotExist, else there would be no compliance check to be initiated (should be caught from before)
ErnestaP
force-pushed
the
compliance-flag
branch
2 times, most recently
from
6ad9db5 to
0d76b31
Compare
ErnestaP
force-pushed
the
compliance-flag
branch
from
0d76b31 to
c784a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.