Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authors modal padding fix #189

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Authors modal padding fix #189

merged 1 commit into from
Mar 4, 2024

Conversation

ErnestaP
Copy link
Contributor

@ErnestaP ErnestaP commented Mar 4, 2024

No description provided.

karolina-siemieniuk-morawska
karolina-siemieniuk-morawska requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@karolina-siemieniuk-morawska karolina-siemieniuk-morawska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in increasing the padding in title bar as well as in modal body, and this is not the desired result
Screenshot 2024-03-04 at 11 12 21

This is what we want
Screenshot 2024-03-04 at 11 13 46

karolina-siemieniuk-morawska
karolina-siemieniuk-morawska requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the title and content will be misaligned

Screenshot 2024-03-04 at 11 17 54

I'd suggest changing

scoap3/ui/src/styles/globals.css

Line 520 in b627d23

.ant-modal-body {
to div.ant-modal .ant-modal-body

@ErnestaP
Copy link
Contributor Author

ErnestaP commented Mar 4, 2024

The results of changes:
Screenshot 2024-03-04 at 11 23 14

@ErnestaP ErnestaP marked this pull request as ready for review March 4, 2024 10:26
@ErnestaP
Copy link
Contributor Author

ErnestaP commented Mar 4, 2024

Screenshot-2024-03-04-at-11 39 29
final result

@ErnestaP ErnestaP merged commit be19a6c into SCOAP3:main Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolina-siemieniuk-morawska karolina-siemieniuk-morawska karolina-siemieniuk-morawska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErnestaP @karolina-siemieniuk-morawska