ui: refactor search page and actions #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamfilos
force-pushed
the
release-updates
branch
2 times, most recently
from
7ab0eb6 to
349a722
Compare
| setFilters(initialData); | ||
| const params = new URLSearchParams(searchParams); | ||
| params.delete('publication_year__range'); | ||
| router.replace(pathname + params.toString()) |
There was a problem hiding this comment.
to prevent wrong query after reset (i.e. /searchcountry instead of /search?country) we could do router.replace(pathname + (params.size > 0 ? '?' : '') + params.toString());
pamfilos
force-pushed
the
release-updates
branch
3 times, most recently
from
67f130f to
353e7c1
Compare
karolina-siemieniuk-morawska
approved these changes
Apr 5, 2024
Signed-off-by: pamfilos <[email protected]>
pamfilos
force-pushed
the
release-updates
branch
from
9cbc023 to
31f1511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.