Fixing a bug with --debug=sconscript

[StenGruener]

Fixing a bug with --debug=sconscript where no exit message was emitted on exception catch

• I have created a new test or updated the unit tests to cover the new/changed functionality.
  already present
• I have updated CHANGES.txt (and read the README.rst)
  already present
• I have updated the appropriate documentation
  already present

[bdbaddog]

If your existing test didn't catch this, then there is not a test to check this code change, and really one should be added to satisfy the PR requirements.

[StenGruener]

True, could you kindly help me out an tell me when the return exception is thrown?

…

________________________________ Von: William Deegan ***@***.***> Gesendet: Wednesday, November 29, 2023 7:58:31 PM An: SCons/scons ***@***.***> Cc: Sten Gruener ***@***.***>; Author ***@***.***> Betreff: Re: [SCons/scons] Fixing a bug with --debug=sconscript (PR #4447) BeSecure! This email comes from outside of ABB. Make sure you verify the sender before clicking any links or downloading/opening attachments. If this email looks suspicious, report it by clicking 'Report Phishing' button in Outlook or raising a ticket on MyIS. If your existing test didn't catch this, then there is not a test to check this code change, and really one should be added to satisfy the PR requirements. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/SCons/scons/pull/4447*issuecomment-1832518873__;Iw!!NLW3fF9v!MqxC6QDfIe7k1DsPrWDM-xH-UiqMo_h_-YPpRgsLlJH4qg4HympJ01hT2f1ama9rdy3QPnJKjRjFTAFIKkSMVZFPskI$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQUNYPN6FGCN2TA6OICWIVDYG6AVPAVCNFSM6AAAAAA77XXIG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGUYTQOBXGM__;!!NLW3fF9v!MqxC6QDfIe7k1DsPrWDM-xH-UiqMo_h_-YPpRgsLlJH4qg4HympJ01hT2f1ama9rdy3QPnJKjRjFTAFIKkSMA2lCRL8$>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[bdbaddog]

True, could you kindly help me out an tell me when the return exception is thrown?
…

That exception is generated when you use Return("foo", stop=True), so if you added a second SConstruct in your existing test and checked for the expected output, you should be covered.
Then of course add update to CHANGES/RELEASE with this change, as your previous PR has been included in the last release.

[StenGruener]

@bdbaddog I hope it is okay now, thanks for the hint!

[bdbaddog]

Also entries in CHANGES.txt should be ordered by contributors last name.

[bdbaddog]

Also need blurb in RELEASE.txt, other than that looks good.

Your second test should fail without your fix right?

[StenGruener]

Also need blurb in RELEASE.txt, other than that looks good.

Your second test should fail without your fix right?

this is true

[StenGruener]

other changes also done