Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParseFlags so -stdlib goes in CXXFLAGS #4521

Merged
merged 2 commits into from
May 10, 2024

Conversation

mwichmann
Copy link
Collaborator

(from #4520 @ryandesign)

gpsd 3.25 failed to build with recent clang if -stdlib=libc++ was passed by the user in CXXFLAGS because gpsd used MergeFlags (which uses ParseFlags) to move the flags where SCons thinks they belong, and because SCons did not know where -stdlib goes it put it in CCFLAGS, which was then passed to the C compiler during a test, and clang emitted a warning that the -stdlib flag was unknown, and the test had requested that warnings be turned into errors with -Werror, which caused the test to get the wrong result which caused compilation to fail later.

See: https://gitlab.com/gpsd/gpsd/-/issues/279

It was easier to make a new PR with the additional files to update. This obsoletes PR #4520

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

This is the completion of PR SCons#4520

Signed-off-by: Mats Wichmann <[email protected]>
@bdbaddog bdbaddog merged commit 3e6a7ac into SCons:master May 10, 2024
4 of 5 checks passed
@mwichmann mwichmann added this to the 4.8 milestone May 10, 2024
@mwichmann mwichmann deleted the finish-4520 branch May 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants