Forward port benchmark for type checking #4540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_types.py
had not been modernized. Remove any reference to theunicode
builtin, which will never be present on Py3; stop usingtypes.InstanceType
which was only for old-style classes and never exists on Py3. It is now possible to:to get an up to date timing run of the type checking functions. Note it's probably a good idea to up the counts in
bench.py
, this completes pretty quickly.This is internal-use stuff only, not part of the release or docs.
Here's a run with the repeat counts upped (Note: the
checkInstanceType_is*
functions no longer differ from theoriginal_is*
functions with the dropping of theInstanceType
checks. Next round, we should just get rid of these).