Win32 test speedup - Part 1 #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwichmann
reviewed
May 27, 2024
test/AddOption/multi-arg.py
Outdated
| @@ -36,7 +36,8 @@ | |||
| test.write( | |||
| 'SConstruct', | |||
| """\ | |||
| env = Environment() | |||
| DefaultEnvironment(tools=[]) | |||
| env = Environment(tools=[]) | |||
There was a problem hiding this comment.
why not leave the Environment call out entirely if env is never used? which I'm guessing is the case for this test, of course the diff doesn't show every line
|
Rebasing after #4545 ought to make this go a lot faster - the last recorded run on this one was 34:46. We still want to know how much better the testsuite tweaks here make things. |
…tion which is not needed for this test
bdbaddog
force-pushed
the
win32_test_speedup
branch
from
484f2d7 to
0bf264e
Compare
Done. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling tool initialization in tests where those tools aren't needed.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)