Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests in case running as root #4614

Merged
merged 6 commits into from
Oct 27, 2024
Merged

Conversation

mwichmann
Copy link
Collaborator

@mwichmann mwichmann commented Oct 13, 2024

Although validation tests are not normally run as root, there may be circumstances when it happens - one known case is when the test suite is run as part of a particular Linux distros package construction. It isn't too hard to avoid the few places where we counted on something failing because of permissions, which don't if the user is root - added a few skips.

This is a test-only change, no impact on SCons or docs.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Oct 13, 2024
SCons/CacheDirTests.py Outdated Show resolved Hide resolved
Although validation tests are not normally run as root, there may be
cicrumstances when it happens - one known case is when the test suite
is run as part of a particular Linux distros package construction.
It isn't too hard to avoid the few places where we counted on something
failing because of permissions, which don't if the user is root -
added a few skips.

Signed-off-by: Mats Wichmann <[email protected]>
@bdbaddog bdbaddog merged commit 4d5ecf6 into SCons:master Oct 27, 2024
@mwichmann mwichmann added this to the NextRelease milestone Oct 28, 2024
@mwichmann mwichmann deleted the test/fix-root branch October 28, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants