Add a tag to the cachedir #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbaddog
reviewed
Oct 27, 2024
bdbaddog
reviewed
Oct 27, 2024
bdbaddog
reviewed
Oct 27, 2024
|
Hmmm, I had made the updates to CHANGES and RELEASE, but it looks like they never got committed. I'll fix that when resolving the conflict. |
Since there are now two files to make when a cachedir is created, use the temporary-dir -> rename technique. CacheDir tests no longer pre-create the cache directory, they should be verifying it's created properly upon request (one unit test still makes sure passing an existing empty directory works, too). Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
cachedir-tag
branch
from
1e861f3 to
8a3c2a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are now two files to make when a cachedir is created, use the temporary-dir -> rename technique.
CacheDirtests no longer pre-create the cache directory, they should be verifying it's created properly upon request (one unit test still makes sure passing an existing empty directory works, too).There are no externally visible changes (except the new tag file if someone goes and explicitly looks, but that's an "implementation detail", not part of the behavior).
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).