Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test cleanup - EnvironmentTests #4618

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

mwichmann
Copy link
Collaborator

Convert two huge blocks of test parameters to iterate-over-list from former while-then-del strategy.

This is purly a change of implementation in the test - it doesn't change what the test tests, and there are no changes to scons itself or documentation.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

Convert two huge blocks of test parameters to
iterate-over-list from former while-then-del strategy.

Signed-off-by: Mats Wichmann <[email protected]>
@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Oct 18, 2024
@mwichmann
Copy link
Collaborator Author

Fun when this one glitches - on one of the two Linux builds...

 Failed the following test:
	test/leaky-handles.py

@bdbaddog bdbaddog merged commit cc8ea0f into SCons:master Oct 18, 2024
6 of 8 checks passed
@mwichmann mwichmann added this to the NextRelease milestone Oct 18, 2024
@mwichmann mwichmann deleted the test/envloops branch October 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants