Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js to support non-integer min-width and max-width #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axryp
Copy link

@axryp axryp commented Mar 7, 2017

Expanded code to support non-integer min-width / max-width, e.g. @media (min-width: 61.25em)

Expanded code to support non-integer min-width / max-width, e.g. @media (min-width: 61.25em)
@DonGissel
Copy link

Please, for the love of god, merge this!

@DonGissel
Copy link

@ivankravchenko? Please?

@Tyree
Copy link

Tyree commented Apr 24, 2018

Is this project dead? Really need this merged or I can't use it. :-/

@Tyree
Copy link

Tyree commented Apr 24, 2018

@axryp Have you tested this? I tried adding your changes to the index.js file in my node_modules and it still doesn't put the queries in the correct order. If I change the em values to px, it does. Any ideas?
It seems to put all the floating points in order, but it puts integers above. So, I end up with 50em, then 87.5, 78.125, 37.5em. It puts the integer before the floating points.
If I change 50 to 50.01, it goes into the correct place.
Also doesn't play nice if you have a px based query mixed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants